Add wasm to content security policy for web ssh terminal #48849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, wasm modules imported by xtermjs cannot function. This follows the same policy as web desktop sessions
avatus
added
the
no-changelog
avatus
requested review from
kimlisa,
ryanclark and
rudream
and removed request for
r0mant and
bernardjkim
ryanclark
approved these changes
Nov 13, 2024
ravicious
approved these changes
Nov 13, 2024
public-teleport-github-review-bot
bot
removed request for
kimlisa and
rudream
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
avatus
added a commit
that referenced
this pull request
Nov 13, 2024
Without this, wasm modules imported by xtermjs cannot function. This follows the same policy as web desktop sessions
This was referenced Nov 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
* Add xterm/image-addon to web terminal This allows the terminal in the web UI to "pretty print" images based on the supported protocols (SIXEL and IIP) * Add wasm to content security policy for web ssh terminal (#48849) Without this, wasm modules imported by xtermjs cannot function. This follows the same policy as web desktop sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, wasm modules imported by xtermjs cannot function. This follows the same policy as web desktop sessions.
#48780 requires this to function (it is available in the vite dev server which is why it wasn't caught until backports).
I will manually add this change to the already open backports